Skip to content

feat(profiling): add llm.agent.phase profiling feature flag#11528

Closed
jbachorik wants to merge 1 commit into
masterfrom
jb/llm-ddt-1-config
Closed

feat(profiling): add llm.agent.phase profiling feature flag#11528
jbachorik wants to merge 1 commit into
masterfrom
jb/llm-ddt-1-config

Conversation

@jbachorik

@jbachorik jbachorik commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Adds PROFILING_CONTEXT_ATTRIBUTES_LLM_PHASE_ENABLED to ProfilingConfig and isLlmPhaseAttributeEnabled(ConfigProvider) to DatadogProfilerConfig.

Motivation

The llm.agent.phase context attribute slot must be registered at profiler startup — ContextSetter is built once and offsetOf() returns -1 for any name not present at construction time. This flag (default true) gates the registration, matching the PROFILING_CONTEXT_ATTRIBUTES_SPAN_NAME_ENABLED pattern and allowing operators to opt out without disabling the profiler.

Part of PROF-14858 (LLM phase attribution). Stacked: base (master) → [ddt-2-profiler] → [ddt-3-lc4j] → [ddt-4-demo].

Additional Notes

No behaviour change until the slot registration in the next PR in this stack.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: PROF-14861

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

Run system tests | main / End-to-end #5 / spring-boot 5   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). 1 failed test: AssertionError: Request failed: None

DataDog/apm-reliability/dd-trace-java | Ubuntu_24_10_amd64.SI94: [test-app-java-buildpack]   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Provisioning errors in the virtual machine steps causing test failures. Check Ubuntu_24_10_amd64.log for details.

DataDog/apm-reliability/dd-trace-java | config-inversion-linter   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Undocumented Environment Variables found in ProfilingConfig.java:226. Missing from '/go/src/github.com/DataDog/apm-reliability/dd-trace-java/metadata/supported-configurations.json'.

View all 9 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 999dc00 | Docs | Datadog PR Page | Give us feedback!

@PerfectSlayer PerfectSlayer added tag: ai generated Largely based on code generated by an AI or LLM and removed AI labels Jun 3, 2026
@jbachorik jbachorik closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: ai generated Largely based on code generated by an AI or LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants